Re: [PATCH v3 5/5] diff: the -w option breaks --exit-code for --raw and other output modes
From: Junio C Hamano <hidden>
Date: 2023-08-21 22:16:54
Jeff King [off-list ref] writes:
quoted hunk
Alternatively, we could put it in the caller, like so:diff --git a/diff.c b/diff.c index 78f4e7518f..e7281e75eb 100644 --- a/diff.c +++ b/diff.c@@ -6528,6 +6528,7 @@ void diff_flush(struct diff_options *options) if (check_pair_status(p)) flush_one_pair(p, options); } + options->found_changes = !!q->nr; separator++; }
Yup, I suspect they amount to the same thing in practice, but I couldn't come up with a good explanation to give casual readers of the conditional call to flush_one_pair() a few lines above why this is correct.