Re: [PATCH 0/2] repack: prevent geometry struct leak

On Wed, Aug 09, 2023 at 04:32:36PM -0400, Taylor Blau wrote:

This short series combines a patch from Peff and a patch from me to
prevent leaking the 'struct pack_geometry *' pointer from the repack
code.

The first patch free()s the heap-allocated struct, and the second
patch moves the variable to be allocated on the stack.

Thanks for cleaning up your patch. I think Junio has the first one in
'next' already as jk/repack-leakfix, but your patch 2 can go on top.

The result looks good to me. It's a little unusual that the "init"
function expects the caller to have already initialized-to-zero and set
the split_factor field, but I think that's OK for a struct that is
limited to this one file.

-Peff