Re: [PATCH] t9001: fix/unify indentation regarding pipes somewhat
From: Junio C Hamano <hidden>
Date: 2023-08-09 19:46:40
Possibly related (same subject, not in this thread)
- 2023-08-13 · Re: [PATCH] t9001: fix/unify indentation regarding pipes somewhat · Oswald Buddenhagen <hidden>
- 2023-08-10 · Re: [PATCH] t9001: fix/unify indentation regarding pipes somewhat · Junio C Hamano <hidden>
- 2023-08-09 · [PATCH] t9001: fix/unify indentation regarding pipes somewhat · Oswald Buddenhagen <hidden>
Oswald Buddenhagen [off-list ref] writes:
quoted hunk
@@ -61,8 +61,8 @@ test_no_confirm () { --smtp-server="$(pwd)/fake.sendmail" \ $@ \ $patches >stdout && - ! grep "Send this email" stdout && - >no_confirm_okay + ! grep "Send this email" stdout && + >no_confirm_okay }
It is hard to see what is going on here, but ...
quoted hunk
@@ -1197,7 +1197,7 @@ test_expect_success $PREREQ 'utf8 Cc is rfc2047 encoded' ' --smtp-server="$(pwd)/fake.sendmail" \ outdir/*.patch && grep "^ " msgtxt1 | - grep "=?UTF-8?q?=C3=A0=C3=A9=C3=AC=C3=B6=C3=BA?= <utf8@example.com>" + grep "=?UTF-8?q?=C3=A0=C3=A9=C3=AC=C3=B6=C3=BA?= <utf8@example.com>"
... I do not think we want this. A long pipeline should be written without extra indentation like A | B | C but more like A | B | C If we do not have it in the coding guidelines document, perhaps we should add an entry for it. Thanks.