Re: [PATCH] t9001: remove excessive GIT_SEND_EMAIL_NOTTY=1
From: Junio C Hamano <hidden>
Date: 2023-08-09 19:43:27
Oswald Buddenhagen [off-list ref] writes:
This was added by 3ece9bf0f9 (send-email: clear the $message_id after validation, 2023-05-17) for no apparent reason, as this is required only in cases when git's stdin is (must be) redirected, which isn't the case here. Signed-off-by: Oswald Buddenhagen <redacted>
Good eyes. Thanks, will apply.
quoted hunk
--- Cc: Junio C Hamano <redacted> --- t/t9001-send-email.sh | 1 - 1 file changed, 1 deletion(-)diff --git a/t/t9001-send-email.sh b/t/t9001-send-email.sh index 48bf0af2ee..c445859f73 100755 --- a/t/t9001-send-email.sh +++ b/t/t9001-send-email.sh@@ -659,7 +659,6 @@ test_expect_success $PREREQ 'clear message-id before parsing a new message' ' clean_fake_sendmail && echo true | write_script my-hooks/sendemail-validate && test_config core.hooksPath my-hooks && - GIT_SEND_EMAIL_NOTTY=1 \ git send-email --validate --to=recipient@example.com \ --smtp-server="$(pwd)/fake.sendmail" \ $patches $threaded_patches &&