Re: [PATCH 1/5] trailer tests: make test cases self-contained
flat view
From: Linus Arver <hidden>
Date: 2023-08-07 05:50:47
"Linus Arver via GitGitGadget" [off-list ref] writes:
quoted hunk ↗ jump to hunk
From: Linus Arver <redacted> ...@@ -1392,7 +1610,9 @@ test_expect_success 'with failing command using $ARG' ' ' test_expect_success 'with empty tokens' ' - git config --unset trailer.fix.command && + test_config trailer.sign.command "echo \"\$GIT_AUTHOR_NAME <\$GIT_AUTHOR_EMAIL>\"" && + test_config trailer.sign.key "Signed-off-by: " && + test_config trailer.ifexists "addIfDifferent" && cat >expected <<-EOF && Signed-off-by: A U Thor <author@example.com>
In this test and some other places we get the chance to remove invocations of "git config --unset ..." (because we don't leak config state anymore). I will update the commit message accordingly in the next reroll.