Re: [PATCH v1 0/4] Remove obsolete Cygwin support from git-gui

From
Mark Levedahl <hidden>
Date
2023-08-05 14:48:04
Reply to
Junio C Hamano, 2023-06-27
On 6/27/23 13:52, Junio C Hamano wrote:
Mark Levedahl [off-list ref] writes:
quoted
=== This is an update, incorporating responses to Junio's and Eric's
comments:
   -- clarified what the "upstream" git-gui branch is
   -- Removed some changes from patch 2 as requested by Junio, reducing
      changes in patch 3 and patch 4
        All code is fixed only after applying patch 4
        Differences in patch 3 and 4 are minimimized
    -- updated comments to clarify G4w dedicated code.
    -- updated all comments to (hopefully) clarify points of confusion
===
...
Mark Levedahl (4):
   git gui Makefile - remove Cygwin modifications
   git-gui - remove obsolete Cygwin specific code
   git-gui - use cygstart to browse on Cygwin
   git-gui - use mkshortcut on Cygwin

  Makefile                  |  21 +------
  git-gui.sh                | 118 +++-----------------------------------
  lib/choose_repository.tcl |  27 +--------
  lib/shortcut.tcl          |  31 +++++-----
  4 files changed, 27 insertions(+), 170 deletions(-)
OK, Dscho says v1 looks good, and I have no further comments.

Pratyush, can I expect that you take further comments and usher
these patches to your tree, and eventually tell me to pull from your
repository?

Thanks, all.
Junio,

Thank you and Dscho for the detailed reviews. But, there is no response from Pratyush in over a month, is there a different maintainer then who should take this?

Mark
Thread (3 messages) 3 messages, 2 authors, last reply 2023-08-29
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help