Thread (1 message) 1 message, 1 author, 2023-07-21

Re: [PATCH] pack-objects: fix --no-keep-true-parents

From: Junio C Hamano <hidden>
Date: 2023-07-21 17:04:05

René Scharfe [off-list ref] writes:
Since 99fb6e04cb (pack-objects: convert to use parse_options(),
2012-02-01) git pack-objects has accepted --no-keep-true-parents, but
this option does the same as --keep-true-parents.  That's because it's
defined using OPT_SET_INT with a value of 0, which sets 0 when negated
as well.

Turn --no-keep-true-parents into the opposite of --keep-true-parents by
using OPT_BOOL and storing the option's status directly in a variable
named "grants_keep_true_parents" instead of in negative form in
"grant" -> "graft" (locally fixed, no need to resend).
"grafts_replace_parents".

Signed-off-by: René Scharfe <redacted>
---
Thanks.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help