Re: [PATCH 02/20] packfile.c: prevent overflow in `load_idx()`

Phillip Wood [off-list ref] writes:

quoted

-		p->crc_offset = 8 + 4 * 256 + nr * hashsz;
+		p->crc_offset = st_add(8 + 4 * 256, st_mult(nr, hashsz));

p->crc_offset is a uint32_t so we're still prone to truncation here

Good eyes.  Thanks.