Re: [RFC PATCH 6/8] pager: remove pager_in_use()

From
Junio C Hamano <hidden>
Date
2023-06-28 17:30:41
Calvin Wan [off-list ref] writes:
quoted
Glen Choo [off-list ref] writes:
quoted
                     Could we add a is_pager/pager_in_use to that
function and push the pager.h dependency upwards?
Bleh, I meant "Could we add a new is_pager/pager_in_use parameter to
that function?"
Refactoring the function signature to:

parse_date_format(const char *format, struct date_mode *mode, int pager_in_use)

as you suggested is a much better solution, thanks! I'll make that
change in the next reroll.
Yeah, the date format "auto:" that changes behaviour between the
output medium feels a serious layering violation, but given the
constraints, it looks like the best thing to do.

Thanks.
Thread (1 message) 1 message, 1 author, last reply 2023-06-28
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help