Derrick Stolee [off-list ref] writes:
However, I think the 'settings->hash_version' is the wrong place
to look for the condition. We should be getting this value from the
commit-graph we are reading. (More on this later.)
...
quoted
- if (hash_version != 1)
+ if (hash_version != d->commit_graph_changed_paths_version)
return 0;
This makes it appear like we cannot read a commit-graph that has
a Bloom filter version that doesn't match the configured version.
This seems incorrect. If we want to configure to _write_ v2, we
should still be able to _read_ v1 concurrently until those v2
filters are written.
Good eyes. Thanks for carefully reading.