Re: [PATCH] http: handle both "h2" and "h2h3" in curl info lines
From: Jeff King <hidden>
Date: 2023-06-17 08:07:15
On Sat, Jun 17, 2023 at 01:15:59AM -0400, Jeff King wrote:
Ah, I see. It looks like it depends on which version of curl is using. Perhaps the macOS image in CI has been updated (or maybe the new version just became available via brew or something). I was able to replicate on my Linux system by building and linking against curl 8.1.0, and the patch above (modulo some missing parentheses) fixes it.
Oh, and just to solve this one remaining riddle: it was indeed a change in the images. If you click through to the log of the failing osx-clang job in your first link, then expand "Set up job" and then "Runner image", you'll see that it was using: https://github.com/actions/runner-images/blob/macOS-12/20230612.1/images/macos/macos-12-Readme.md which mentions curl 8.1.2. Whereas on your other link (where the jobs did not fail), it was last month's: https://github.com/actions/runner-images/blob/macOS-12/20230516.1/images/macos/macos-12-Readme.md which has curl 8.0.1. So presumably every CI run from here forward will fail unless we patch it. -Peff