Thread (45 messages) 45 messages, 2 authors, 2023-06-17

Re: [PATCH 05/11] branch: fix a leak in setup_tracking

From: Rubén Justo <hidden>
Date: 2023-06-16 22:46:25

On 11-jun-2023 23:26:15, Jeff King wrote:
On Sun, Jun 11, 2023 at 08:49:51PM +0200, Rubén Justo wrote:
quoted
The return introduced in bdaf1dfae7 was to avoid setting up the
tracking, but even in that case it is still necessary to do the
clean-up.  Let's do it.
That may be a sign that the return introduced by that commit is in the
wrong spot (i.e., could we be checking it earlier and returning before
doing the work that led to the allocations?).

But I didn't look too carefully, and I think for the purposes of your
series it is OK to simply fix the leak without digging too far.
Thanks.
I'll cc the author (and quote the patch below) though, as sometimes in
cases like these they may be interested in looking deeper themselves.
Perfect.  Thank you.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help