Re: [PATCH v3 0/4] Changed path filter hash fix and version bump
From: Jonathan Tan <hidden>
Date: 2023-06-13 17:16:50
Possibly related (same subject, not in this thread)
- 2023-06-13 · Re: [PATCH v3 0/4] Changed path filter hash fix and version bump · Junio C Hamano <hidden>
- 2023-06-09 · Re: [PATCH v3 0/4] Changed path filter hash fix and version bump · Jonathan Tan <hidden>
- 2023-06-08 · Re: [PATCH v3 0/4] Changed path filter hash fix and version bump · Ramsay Jones <hidden>
- 2023-06-08 · [PATCH v3 0/4] Changed path filter hash fix and version bump · Jonathan Tan <hidden>
Junio C Hamano [off-list ref] writes:
quoted hunk ↗ jump to hunk
Perhaps an addition to Documentation/CodingGuidelines is in order? Documentation/CodingGuidelines | 9 +++++++++ 1 file changed, 9 insertions(+)diff --git c/Documentation/CodingGuidelines w/Documentation/CodingGuidelines index 9d5c27807a..78bc60665d 100644 --- c/Documentation/CodingGuidelines +++ w/Documentation/CodingGuidelines@@ -188,6 +188,15 @@ For shell scripts specifically (not exhaustive): hopefully nobody starts using "local" before they are reimplemented in C ;-) + - In 'printf' format string, do not use hexadecimals, as they are not + portable. Write + + CENT=$(printf "\302\242") + + not + + CENT=$(printf "\xc2\xa2")
I've checked with "dash" and this applies to any quoted string, not just when passed to printf. I'll prepare a patch describing this.