Thread (1 message) 1 message, 1 author, 2023-06-12

Re: [PATCH v5 2/2] gc: introduce `gc.recentObjectsHook`

From: Junio C Hamano <hidden>
Date: 2023-06-12 21:21:02

Glen Choo [off-list ref] writes:
Taylor Blau [off-list ref] writes:
quoted
When performing a garbage collection operation on a repository with
unreachable objects, Git makes its decision on what to do with those
object(s) bed on how recent the objects are or not. Generally speaking,
s/bed/based/ ?
Indeed.  Also "or not" sounds a bit extraneous.
quoted
+		if (parse_oid_hex(buf.buf, &oid, &rest) || *rest) {
+			ret = error(_("invalid extra cruft tip: '%s'"), buf.buf);
To be consistent with the other error message, perhaps s/extra cruft
tip/additional recent object/?
Sharp eyes.
Aside from those trivial points, everything looks good.
Thanks for reviewing (and writing).
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help