Thread (4 messages) 4 messages, 3 authors, 2023-06-06

Re: [PATCH] statinfo.h: move DTYPE defines from dir.h

From: Alejandro Sedeño <hidden>
Date: 2023-06-03 03:02:32

Possibly related (same subject, not in this thread)

Sorry for the dupes; resending as plain-text as per list requirements.

On Fri, Jun 2, 2023 at 9:56 PM Junio C Hamano [off-list ref] wrote:
"Alejandro R Sedeño" [off-list ref] writes:
quoted
…
Signed-off-by: Alejandro R. Sedeño <redacted>
Signed-off-by: Alejandro R Sedeño <redacted>
They are both me; it's my way of sticking with my historical personal
address and still attaching my work address for work reasons.

This is a bit unusual; do you want to publish both names (I am
assuming that they are the same single person)?

I thought somebody in the earlier discussion identified the topic
that was problematic by bisecting.  It is a shame to lose that.
I identified it earlier, by inspection because the machine I build on
is slow and this was easy to track down.
Perhaps it is a good idea to rephrase the beginning of the proposed
commit log message to mention that, like

    592fc5b3 (dir.h: move DTYPE defines from cache.h, 2023-04-22)
    moved DTYPE macros from cache.h to dir.h, but are still used
    by cache.h to implement ce_to_dtype(); but cache.h cannot
    include dir.h because ...

or something?
Happy to rephrase.

-Alejandro
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help