Thread (28 messages) 28 messages, 6 authors, 2023-06-06

Re: [PATCH v2 0/3] Create stronger guard rails on replace refs

From: Elijah Newren <hidden>
Date: 2023-06-03 01:52:46

Hi,

On Fri, Jun 2, 2023 at 7:29 AM Derrick Stolee via GitGitGadget
[off-list ref] wrote:
[...]
Updates in v2
=============

Thanks for the careful review on v1!

 * disable_replace_refs() now replaces "read_replace_refs = 0" in the exact
   same line to avoid possible behavior change.
 * Stale comments, include headers, and commit messages are updated to
   include the latest status.
 * Patch 3 contains a test of the repo-scoped value using 'git grep'.
This version looks good to me; thanks for working on it!

(As a sidenote, it might be nice to call out Victoria's questions
about possibly moving stuff to environment.h[1], so that if others
have opinions on the matter they can comment on it.  I don't have one
at this time.)

[1] Last paragraph of
https://lore.kernel.org/git/49ea603b-ebbd-4a14-e0dd-07078e56de0a@github.com/ (local)
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help