Thread (16 messages) 16 messages, 2 authors, 2023-05-22

Re: [PATCH 2/9] fetch: drop unneeded NULL-check for `remote_ref`

From: Jeff King <hidden>
Date: 2023-05-19 00:13:59

On Wed, May 17, 2023 at 01:48:46PM +0200, Patrick Steinhardt wrote:
Drop the `NULL` check for `remote_ref` in `update_local_ref()`. The
function only has a single caller, and that caller always passes in a
non-`NULL` value.

This fixes a false positive in Coverity.
Thanks for following up on this. I was thinking of just reposting it,
thinking there weren't that many other cleanups to do in fetch.c. But
you found quite a few. :)

The patch looks obviously good to me.

-Peff
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help