Re: [PATCH v5 7/7] strbuf: remove global variable

Phillip Wood [off-list ref] writes:

Hi Calvin

On 11/05/2023 20:48, Calvin Wan wrote:

quoted

As a library that only interacts with other primitives, strbuf should
not utilize the comment_line_char global variable within its
functions. Therefore, add an additional parameter for functions that use
comment_line_char and refactor callers to pass it in instead.
strbuf_stripspace() removes the skip_comments boolean and checks if
comment_line_char is a non-NULL character to determine whether to skip
comments or not.

Thanks for re-rolling, I agree with Eric's comments but would be happy
if this was merged as-is.

Thanks for reviewing.