Thread (6 messages) 6 messages, 4 authors, 2023-05-02

Re: [PATCH v2] credential: new attribute oauth_refresh_token

From: Jeff King <hidden>
Date: 2023-05-02 10:28:10

On Tue, Apr 25, 2023 at 08:19:40PM +0100, M Hickford wrote:
quoted
quoted
Add support for the new attribute to credential-cache. Eventually, I
hope to see support in other popular storage helpers.
At least your optimism is documented. :)
I have a draft patch for credential-libsecret
https://github.com/gitgitgadget/git/pull/1524 which I could add to
this patch series if you like. Helpers credential-wincred and
credential-osxkeychain would be easy to update following the same
approach.
Good, thanks for doing that work. I don't think it needs to be part of
this series. Knowing that it's being worked on gives a sense that this
patch is going in a useful direction.

I do find the "shove extra data into the password field" strategy a
little gross, but that may be the best that can be done when interfacing
with existing stores. And at least the details are all contained inside
the helper itself (though I guess a user looking at it with other wallet
management tools would see the weird field).

-Peff
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help