Re: [PATCH v2 0/5] some chainlint fixes and performance improvements
From: Jeff King <hidden>
Date: 2023-03-30 22:09:26
From: Jeff King <hidden>
Date: 2023-03-30 22:09:26
On Thu, Mar 30, 2023 at 01:32:34PM -0700, Junio C Hamano wrote:
quoted
[5/5]: tests: skip test_eval_ in internal chain-lintThe new step [3/5] makes it easier to justify [4/5], indeed. Two primary changes at the beginning are good as before. The last one does not make anything particularly easier to read, replacing one cryptic eval stuff with another, but it does not make it any worse, and the most importantly, it is clear to see that it does not change the behaviour.
Yeah, the eval garbage is horrid no matter where it is. The improvement is that we no longer have to manually save-and-restore the "trace" variable.
Will queue. Thanks. Let's merge it down to 'next'.
Great, thanks. :) -Peff