Re: [PATCH v3 3/8] config.c: create config_reader and the_reader
From: Glen Choo <hidden>
Date: 2023-03-29 20:02:28
From: Glen Choo <hidden>
Date: 2023-03-29 20:02:28
Junio C Hamano [off-list ref] writes:
quoted
quoted
I.e. we actually *do* have a repo there, we just haven't bridged the gap of "ignore most of its config" so we can use config_with_options() there.struct config_options { unsigned int respect_includes : 1; + unsigned int ignore_system : 1; + unsigned int ignore_global : 1; unsigned int ignore_repo : 1; + unsigned int ignore_local : 1; unsigned int ignore_worktree : 1; unsigned int ignore_cmdline : 1; unsigned int system_gently : 1;That does look (I am not sure about _local bit, though) well organized, but I suspect that it can be left for a follow-on clean-up series, perhaps?
Makes sense, I did suggest something similar previously: https://lore.kernel.org/git/kl6ly1oze7wb.fsf@chooglen-macbookpro.roam.corp.google.com (local) But I think that's a follow up series for sure.