Thread (4 messages) 4 messages, 2 authors, 2023-03-20

Re: [PATCH 0/2] Remove unnecessary inclusions of parse-options.h from headers

From: Elijah Newren <hidden>
Date: 2023-03-20 16:49:37

On Sun, Mar 19, 2023 at 10:13 AM SZEDER Gábor [off-list ref] wrote:
Some source files use parse_options(), but don't include
parse-options.h, while some headers do include parse-options.h, though
don't really need it.  These patches fix these issues.
Nice!

Reviewed-by: Elijah Newren <redacted>
This series has a small and simple conflict with the 'ds/ahead-behind'
topic, and it will have small conflicts with Elijah's header cleanup
series as well:

  https://public-inbox.org/git/pull.1493.git.1679207282.gitgitgadget@gmail.com/T/#t
Perhaps it makes sense to rebase your series on that one?  (And/or add
the headers earlier in the list instead of at the end to reduce the
odds of patch collisions?  I really wish we had our #include's in
alphabetical order instead of always appending to the end, because it
both reduces the odds of conflicts and is so much easier for humans to
check.)
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help