Thread (1 message) 1 message, 1 author, 2023-03-09

Re: [PATCH v7 0/9] config API: make "multi" safe, fix segfaults, propagate "ret"

From: Junio C Hamano <hidden>
Date: 2023-03-09 20:47:50

Glen Choo [off-list ref] writes:
Ævar Arnfjörð Bjarmason [off-list ref] writes:
quoted
This series fixes numerous segfaults in config API users, because they
didn't expect *_get_multi() to hand them a string_list with a NULL in
it given config like "[a] key" (note, no "="'s).

A larger general overview at v1[1], but note the API changes in
v2[2]. Changes since v6[3]:

 * Glen pointed out that ejecting a commit in v6 orphaned a
   corresponding forward-reference in a commit message, fix that.
Thanks for your patience with the rerolls :) I only spotted a minor
comment issue [1] (which I think was what originally motivated v5?).
IMO this will be mergeable once we reorder that comment.

1. https://lore.kernel.org/git/kl6ledpxhi3t.fsf@chooglen-macbookpro.roam.corp.google.com/ (local)
Thanks for carefully reading these patches.  I agree that this round
is in quite a good shape.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help