Thread (4 messages) 4 messages, 3 authors, 2023-02-25

Re: [PATCH v4 1/3] rebase: add documentation and test for --no-rebase-merges

From: Junio C Hamano <hidden>
Date: 2023-02-24 19:16:16

Johannes Schindelin [off-list ref] writes:
On Thu, 23 Feb 2023, Junio C Hamano wrote:
quoted
Alex Henrie [off-list ref] writes:
quoted
Signed-off-by: Alex Henrie <redacted>
---
No cover letter to summarize the changes?
A range-diff would have been nice, too, as well as replying-to the
previous iteration so that they're all within the same email thread.
Yes, especially the threading would help both those who missed
previous iterations and those who reviewed them.  Range-diff is
often helpful when came with a good summary.  Just like a patch
alone without a good proposed log message is not a good way to help
reviewers understand the issue the patch tries to solve, a cover
with range-diff alone only shows what is different from the previous
iteration, but does not say why the changes were made, so it is not
a good substitute for an explanation by author's words.

I may have suggested GGG if the author appeared a total beginner
with the e-mail workflow (and especially if it were a single-patch
topic), but Alex seems to be doing fine otherwise, and also GGG has
its own learning curve (e.g. it is rare to see a good cover letter
with per-iteration summaries, unless the author is one of those
experienced list regulars), so I left it up to Alex to choose how to
reach the desired end result.

Thanks.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help