Thread (68 messages) 68 messages, 7 authors, 2023-03-26

Re: [PATCH v4 2/3] rebase: stop accepting --rebase-merges=""

From: Johannes Schindelin <hidden>
Date: 2023-02-24 13:54:26

Hi Alex,

On Wed, 22 Feb 2023, Alex Henrie wrote:
The unusual syntax --rebase-merges="" (that is, --rebase-merges with an
empty string argument) has been an undocumented synonym of
--rebase-merges=no-rebase-cousins. Stop accepting that syntax to avoid
confusion when a rebase.merges config option is introduced, where
rebase.merges="" will be equivalent to not passing --rebase-merges.
Being undocumented and obscure might be a good reason for some to consider
this a bug; I do not. You could deprecate it, but there are probably
better ideas than to remove it without prior warning.

If all you want to do is to support `rebase.merges=`, you can do that
without having to change the meaning of `--rebase-merges=`.

Ciao,
Johannes
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help