Thread (9 messages) 9 messages, 3 authors, 2023-02-21

Re: [GSOC][PATCH v2 1/1] t4121: modernize test style

From: Vivan Garg <hidden>
Date: 2023-02-21 22:34:50

On Tue, Feb 21, 2023 at 3:17 PM Victoria Dye [off-list ref] wrote:
The new commit message is sufficiently descriptive, thanks for updating. In
terms of readability, it is a bit of a run-on sentence (the comma after
"lines" could be a period, i.e. "...separate lines. Therefore, update
the..."). I don't think it needs to be updated, but it's something to keep
in mind for future contributions. :)
I've taken note of it. Thanks!
Whitespace looks good here. I think this is ready-to-merge; thanks!
Thanks again for the review!
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help