Re: [PATCH 1/1] range-diff: let '--abbrev' option takes effect
From: Junio C Hamano <hidden>
Date: 2023-02-21 22:01:44
Teng Long [off-list ref] writes:
quoted hunk
diff --git a/range-diff.c b/range-diff.c index 8255ab43..086365df 100644 --- a/range-diff.c +++ b/range-diff.c@@ -383,11 +383,14 @@ static void output_pair_header(struct diff_options *diffopt, const char *color_new = diff_get_color_opt(diffopt, DIFF_FILE_NEW); const char *color_commit = diff_get_color_opt(diffopt, DIFF_COMMIT); const char *color; + char abbrev = diffopt->abbrev; + + if (abbrev < 0) + abbrev = DEFAULT_ABBREV;
OK. I _think_ this explicit defaulting to DEFAULT_ABBREV does not need to exist, as find_unique_abbrev() falls back to the default when given a negative value anyway, but it is good to be explicit. Will queue. Thanks.