Thread (1 message) 1 message, 1 author, 2023-02-09

Re: [PATCH] gpg-interface: lazily initialize and read the configuration

From: Junio C Hamano <hidden>
Date: 2023-02-09 16:38:19

Jeff King [off-list ref] writes:
This all looks fairly sensible to me. I think we'd really want to see a
"rev-list --format" test, too. One, because that's the immediate goal of
this change.
Heh. I primarily wanted to see how much damage to the code does it
take to implement such a lazy-loading scheme ;-)  Which turned out
to be "not much".

Maybe when I have time next time, but no promises.
But two, because I think we are only guessing that loading
the config is sufficient here. We've had bug with other subsystems where
they expected to be initialized but plumbing callers didn't (e.g., the
lazy init of notes-refs, etc).
Yup.
I _think_ we're probably good here. Just looking at "git log" (where we
know --format, etc, works), it doesn't seem to do anything beyond
initializing the config.
That was my recollection from back when gpg-interface was split out
of "git tag".

Thanks for sanity checking.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help