Re: [PATCH v2 1/5] run-command.c: remove dead assignment in while-loop
From: Junio C Hamano <hidden>
Date: 2023-02-08 21:03:35
Ævar Arnfjörð Bjarmason [off-list ref] writes:
Remove code that's been unused since it was added in c553c72eed6 (run-command: add an asynchronous parallel child processor, 2015-12-15).
Obviously correct. Thanks, will queue.
quoted hunk
Signed-off-by: Ævar Arnfjörð Bjarmason <redacted> --- run-command.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-)diff --git a/run-command.c b/run-command.c index 50cc011654e..b439c7974ca 100644 --- a/run-command.c +++ b/run-command.c@@ -1632,9 +1632,7 @@ static void pp_buffer_stderr(struct parallel_processes *pp, const struct run_process_parallel_opts *opts, int output_timeout) { - int i; - - while ((i = poll(pp->pfd, opts->processes, output_timeout) < 0)) { + while (poll(pp->pfd, opts->processes, output_timeout) < 0) { if (errno == EINTR) continue; pp_cleanup(pp, opts);