Thread (1 message) 1 message, 1 author, 2023-02-08

Re: CMakeLists.txt from contrib/buildsystems fails to build on Mac

From: Junio C Hamano <hidden>
Date: 2023-02-08 16:53:35

Phillip Wood [off-list ref] writes:
On 08/02/2023 11:57, Ævar Arnfjörð Bjarmason wrote:
quoted
Or rather, that GFW would be fixing it up, but then I don't see why it
should be in git.git, which as your message shows just leads to
confusion about why this component is in git.git's tree.
I think Ilya's message shows we need to update the instructions in
CMakeLists.txt to make it clear it is Windows only.
That matches the conclusion in the thread

  https://lore.kernel.org/git/1e701a54-0356-9f55-ab53-9d8bfdd93e55@dunelm.org.uk/ (local)

which was a subthread of the primary discussion we had on this
topic, which starts here:

  https://lore.kernel.org/git/544fff8a-7d56-57a1-00a3-d1a9302e227c@dunelm.org.uk/ (local)

I am fine with either marking CMakeLists as windows-only, or
removing it from my tree and have GfW folks add it back to their
tree.

Or keep it in my tree, make CI failures around it "soft" failures,
and mark it prominently as "work in progress" on platforms other
than Windows.  But this choice is only valid if we as the project
want to expend more effort on enhancing and extending cmake support.
I personally do not believe in having to maintain two parallel build
systems for non Windows and keep them in sync.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help