Thread (5 messages) 5 messages, 3 authors, 2023-02-08

Re: [GSoC][PATCH] commit: warn the usage of reverse_commit_list() helper

From: Junio C Hamano <hidden>
Date: 2023-02-07 18:53:46

Kousik Sanagavarapu [off-list ref] writes:
-/* Modify list in-place to reverse it, returning new head; list will be tail */
+/*
+ * Modify list in-place to reverse it, returning new head; list will be tail.
+ *
+ * NOTE! The reversed list is constructed using the elements of the original
+ * list, hence losing the original list.
+ */
After re-reading the original, I realize that "in-place" is good
enough clue to say that this is destructive.


Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help