Thread (1 message) 1 message, 1 author, 2023-02-07

Re: [PATCH v5 00/10] config API: make "multi" safe, fix segfaults, propagate "ret"

From: Junio C Hamano <hidden>
Date: 2023-02-07 17:39:05

Ævar Arnfjörð Bjarmason  [off-list ref] writes:
* Added tests for value-less at the end of a list to 2/10, per Junio's
  request.
I do not "request" anything during my reviews, and I prefer not to
see that verb.  If you find what a reviewer suggests is valuable,
you take it, otherwise you explain why it is better to go without
what was suggested.
  As the much of the point of this series is to make that API less of
  a special snowflake a new 6/10 instead finishes up the work of
  having most of the rest of the API return the un-coerced "ret" from
  the depths of the config API.

  That patch is quite large by line count, but pretty trivial in
  complexity. All of those functions are copy/pasted versions of one
  another with very minor variations.

* Updated the 8/10 commit message, which was stale from a previous
  version of this topic.
This is now 9/10, thanks to the new 6/10 step being added, and it
reads well.

Thanks, will queue.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help