Re: [PATCH v3 3/3] t4113: indent with space

From
Shuqi Liang <hidden>
Date
2023-02-06 21:17:33
Reply to
Eric Sunshine, 2023-02-05
Hi, Eric

On Sun, Feb 5, 2023 at 3:30 PM Eric Sunshine [off-list ref] wrote:
This probably ought to say "indent with tab" since that's what this
patch is doing.
Thanks ,I will fix it .
If you do find a reason to re-roll, though, I might suggest swapping
patches 2 and 3 since the current organization leaves a mix of tab and
space indentation in the tests, which makes reviewers do extra work
since they have to look ahead in the patch series to see if you fix
the inconsistent indentation in a later patch.
Yeah ,I didn‘t realize that .Thanks for reply! I will send the V4 soon.
----------
Thanks,
Shuqi
Thread (32 messages) 32 messages, 4 authors, last reply 2023-02-15
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help