Re: [PATCH 1/4] t/lib-httpd: bump required apache version to 2.2
From: Jeff King <hidden>
Date: 2023-02-03 17:19:35
From: Jeff King <hidden>
Date: 2023-02-03 17:19:35
On Wed, Feb 01, 2023 at 11:39:37PM -0500, Todd Zullinger wrote:
quoted
diff --git a/t/lib-httpd.sh b/t/lib-httpd.sh index 608949ea80..8fc411ff41 100644 --- a/t/lib-httpd.sh +++ b/t/lib-httpd.sh@@ -99,16 +99,19 @@ then fi HTTPD_VERSION=$($LIB_HTTPD_PATH -v | \Trivial, but is it worth getting rid of the unnecessary backslash, while you're improving things here? Maybe that's a mild tangent for code that's otherwise not adjusted very often?
Heh, I didn't even notice. I don't think it's a big deal either way. It definitely doesn't match our style, and I don't mind if we fix it on top, but it could just be left alone. It might make more sense as part of a broader cleanup. Running: git grep '| \\' turns up a number of hits. -Peff