Re: [PATCH v7 00/12] Enhance credential helper protocol to include auth headers

From
Junio C Hamano <hidden>
Date
2023-01-26 16:05:23
Jeff King [off-list ref] writes:
quoted
Thanks, both.  Let's merge it down.
Sorry, I'm a bit late to the party, but I left some comments just now
(this topic had been on my review backlog for ages, but I never quite
got to it).

Many of my comments were small bits that could be fixed on top (tiny
leaks, etc). But some of my comments were of the form "no, do it totally
differently". It may simply be too late for those ones, but let's see if
Matthew finds anything compelling in them.
I do not mind reverting the merge to 'next' to have an improved
version.  Your "do we really want to add a custom server based on
questionable codebase whose quality as a test-bed for real world
usage is dubious?" is a valid concern.
Thread (9 messages) 9 messages, 4 authors, last reply 2023-03-28
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help