Thread (23 messages) 23 messages, 4 authors, 2023-02-01

Re: [PATCH 1/6] t1007: modernize malformed object tests

From: Taylor Blau <hidden>
Date: 2023-01-18 21:15:05

On Wed, Jan 18, 2023 at 03:35:30PM -0500, Jeff King wrote:
The tests in t1007 for detecting malformed objects have two
anachronisms:

 - they use "sha1" instead of "oid" in variable names, even though the
   script as a whole has been adapted to handle sha256
I appreciate you saying that we should s/sha1/oid here. But more
importantly, thanks for drawing attention to the fact that this script
already handles sha256, and that the update is purely cosmetic.
---
 t/t1007-hash-object.sh | 18 +++++++++---------
 1 file changed, 9 insertions(+), 9 deletions(-)
These look obviously correct.

Thanks,
Taylor
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help