[PATCH 1/3] http-push: prefer CURLOPT_UPLOAD to CURLOPT_PUT
From: Jeff King <hidden>
Date: 2023-01-15 20:10:40
Subsystem:
the rest · Maintainer:
Linus Torvalds
Possibly related (same subject, not in this thread)
- 2023-01-17 · Re: [PATCH 1/3] http-push: prefer CURLOPT_UPLOAD to CURLOPT_PUT · Jeff King <hidden>
- 2023-01-17 · [PATCH 1/3] http-push: prefer CURLOPT_UPLOAD to CURLOPT_PUT · Jeff King <hidden>
The two options do exactly the same thing, but the latter has been deprecated and in recent versions of curl may produce a compiler warning. Since the UPLOAD form is available everywhere (it was introduced in the year 2000 by curl 7.1), we can just switch to it. Signed-off-by: Jeff King <redacted> --- http-push.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/http-push.c b/http-push.c
index 5f4340a36e..1b18e775d0 100644
--- a/http-push.c
+++ b/http-push.c@@ -198,7 +198,7 @@ static void curl_setup_http(CURL *curl, const char *url, const char *custom_req, struct buffer *buffer, curl_write_callback write_fn) { - curl_easy_setopt(curl, CURLOPT_PUT, 1); + curl_easy_setopt(curl, CURLOPT_UPLOAD, 1); curl_easy_setopt(curl, CURLOPT_URL, url); curl_easy_setopt(curl, CURLOPT_INFILE, buffer); curl_easy_setopt(curl, CURLOPT_INFILESIZE, buffer->buf.len);
--
2.39.0.513.g00e40dbe01