Re: [PATCH v2 0/5] Documentation: updates and a correction around 'ORIG_HEAD'
From: Junio C Hamano <hidden>
Date: 2023-01-13 18:03:48
Phillip Wood [off-list ref] writes:
Hi Philippe On 10/01/2023 13:15, Philippe Blain via GitGitGadget wrote:quoted
* added a link to the mailing list thread in the commit message of 5/5. v1: Documentation: updates and a correction around 'ORIG_HEAD' This series' initial motivation was to clear up a confusion that arose in [1] where it was noticed that 'ORIG_HEAD' is not guaranteed to point to the original branch tip at the end of the rebase if 'git reset' is used during the rebase. Patch 5/5 adds a note to 'git rebase's documentation to make that explicit. When taking a look at the existing documentation mentioning 'ORIG_HEAD', I also found an error in an example (patch 1/5), other small inconsistencies (patch 2-3/5), and a potential improvement (patch 4/5).Thanks for doing this, I think the adding a note to the rebase documentation is a good idea given the confusion that's been reported. The patches all look great to me apart from patch 4 where I share Junio's concerns about the readability and maintenance burden of the list of commands. I was surprised to learn that merge also sets ORIG_HEAD, thanks for being so thorough.
Thanks for reviewing, and thanks for writing, the patch. Let's queue and merge it to 'next'.