Thread (1 message) 1 message, 1 author, 2023-01-06

Re: [PATCH v14 0/2] win32: close handles of threads that have been joined

From: Junio C Hamano <hidden>
Date: 2023-01-06 12:28:05

"Rose via GitGitGadget" [off-list ref] writes:
After joining threads, the handle to the original thread should be closed as
it no longer needs to be open.

Signed-off-by: Seija Kijin doremylover123@gmail.com

Seija Kijin (2):
  win32: prepare pthread.c for change by formatting
  win32: close handles of threads that have been joined

 compat/win32/pthread.c | 25 ++++++++++++++-----------
 1 file changed, 14 insertions(+), 11 deletions(-)


base-commit: 4dbebc36b0893f5094668ddea077d0e235560b16
Published-As: https://github.com/gitgitgadget/git/releases/tag/pr-git-1406%2FAtariDreams%2Fjoin-v14
Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-git-1406/AtariDreams/join-v14
Pull-Request: https://github.com/git/git/pull/1406

Range-diff vs v13:

 1:  6f89b120641 = 1:  a20eafb9541 win32: prepare pthread.c for change by formatting
 2:  f126d6416d5 = 2:  aa0319bc08e win32: close handles of threads that have been joined

In general, the cover letter of a reroll should explain why
reviewers are asked to look at the updated version instead of the
older one, i.e. what changed since the previous iteration and why.
For those who followed and/or participated in the review of previous
iterations, the range-diff might be sufficient to guess why these
changes were made in order to improve what, but for those who are
coming late to the party, it would be helpful if you explain what
you changed, how and why.

This is true especially if (1) you are rerolling even though the
previous round got little reviews or (2) you are resending without
any change.

Thanks.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help