Thread (14 messages) 14 messages, 4 authors, 2024-12-18

Re: [PATCH] maintenance: use xcalloc instead of xmalloc where possible

From: Jeff Hostetler <hidden>
Date: 2022-12-05 15:01:52


On 12/5/22 9:48 AM, Rose via GitGitGadget wrote:
quoted hunk ↗ jump to hunk
From: Seija <redacted>

We can avoid having to call memset by calling xcalloc directly

Signed-off-by: Seija doremylover123@gmail.com
---
     maintenance: use xcalloc instead of xmalloc where possible
     
     We can avoid having to call memset by calling xcalloc directly
     
     Signed-off-by: Seija doremylover123@gmail.com

Published-As: https://github.com/gitgitgadget/git/releases/tag/pr-git-1390%2FAtariDreams%2Fcalloc-v1
Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-git-1390/AtariDreams/calloc-v1
Pull-Request: https://github.com/git/git/pull/1390

  remote.c    | 4 +---
  submodule.c | 3 +--
  2 files changed, 2 insertions(+), 5 deletions(-)
diff --git a/remote.c b/remote.c
index 60869beebe7..75315f3563f 100644
--- a/remote.c
+++ b/remote.c
@@ -2741,9 +2741,7 @@ void apply_push_cas(struct push_cas_option *cas,
  
  struct remote_state *remote_state_new(void)
  {
-	struct remote_state *r = xmalloc(sizeof(*r));
-
-	memset(r, 0, sizeof(*r));
+	struct remote_state *r = xcalloc(1, sizeof(*r));
  
We have a macro to make this easier and hide the messy details:

	struct remote_state *r;

	CALLOC_ARRAY(r, 1);


Jeff
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help