Re: [PATCH] t7610: use "file:///dev/null", not "/dev/null", fixes MinGW
From: Ævar Arnfjörð Bjarmason <hidden>
Date: 2022-11-17 10:09:45
On Tue, Nov 15 2022, Taylor Blau wrote:
On Wed, Nov 16, 2022 at 12:40:14AM +0100, Ævar Arnfjörð Bjarmason wrote:quoted
On MinGW the "/dev/null" is translated to "nul" on command-lines, even though as in this case it'll never end up referring to an actual file. So on Windows the fix for the previous "example.com" timeout issue in 8354cf752ec (t7610: fix flaky timeout issue, don't clone from example.com, 2022-11-05) would yield: fatal: repo URL: 'nul' must be absolute or begin with ./|../ Let's evade this yet again by prefixing this with "file://", which makes this pass in the Windows CI.Thanks very much. I just picked this up on top of my 'ab/t7610-timeout' branch and pushed it out to ttaylorr/git to double-check your results against CI. (Not that I don't trust you, of course, but I'm feeling like I should be extra-cautious ;-)). Assuming that all looks good, then I'll push out a new version of 'next' and dependent branches to the usual spots so that we can get 'next' back to green. Thanks for working on this so quickly.
And thank for picking it up! Looks like "next" is passing CI now: https://github.com/git/git/actions/runs/3475751137/jobs/5810308794