Thread (13 messages) 13 messages, 6 authors, 2022-11-14

Re: [PATCH] docs: clarify that credential discards unrecognised attributes

From: Taylor Blau <hidden>
Date: 2022-11-13 04:56:23

On Sat, Nov 12, 2022 at 11:47:30AM -0500, Jeff King wrote:
On Sat, Nov 12, 2022 at 02:21:24AM +0000, M Hickford wrote:
quoted
On Tue, 25 Oct 2022 at 00:59, Jeff King [off-list ref] wrote:
quoted
On Mon, Oct 24, 2022 at 07:57:48AM +0000, M Hickford via GitGitGadget wrote:
quoted
It was previously unclear how unrecognised attributes are handled.
Yeah, this was always part of the intended behavior, but I agree we did
not say it very explicitly (aside from an in-code comment!). Both the
intent and content of your patch look good to me.
Thanks. What happens next? I should look for this change in the seen
branch? https://git-scm.com/docs/MyFirstContribution#after-approval
Usually the maintainer would pick it up, it would end up in seen, then
eventually 'next', and then eventually 'master'. You can check the
periodic "What's Cooking" messages from the maintainer to see more
discussion of various topic branches.

In this case, though, I don't see any indication that the maintainer
picked saw it. It sometimes happens that a topic is simply overlooked,
even if it received positive reviews.

The usual thing to do is repost it, cc-ing the maintainer. I've also
cc'd the interim maintainer here, so that may get things moving. :)
I think that Junio may have missed it when picking up topics. But it
happened before I start combing the list more finely, so I had already
purged it from my inbox without picking it up, either.

I'll take a look now and queue it to start merging down. Thanks for the
nudge.

Thanks,
Taylor
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help