Re: [PATCH] maintenance: improve error reporting for unregister
From: Taylor Blau <hidden>
Date: 2022-11-11 22:46:05
On Thu, Nov 10, 2022 at 03:53:10PM -0700, Ronan Pigott wrote:
quoted hunk ↗ jump to hunk
diff --git a/builtin/gc.c b/builtin/gc.c index 1709355bce5a..56b107e7f0b9 100644 --- a/builtin/gc.c +++ b/builtin/gc.c@@ -1550,19 +1550,24 @@ static int maintenance_unregister(int argc, const char **argv, const char *prefi usage_with_options(builtin_maintenance_unregister_usage, options); - if (!config_file) { + struct config_set cs;
This declaration should go at the beginning of the function.
+ if (config_file) {
+ git_configset_init(&cs);
+ git_configset_add_file(&cs, config_file);
+ list = git_configset_get_value_multi(&cs, key);And these assignments conflict with 'ab/config-multi-and-nonbool', but that is a problem for me to figure out, not you. Thanks, Taylor