[PATCH v3 2/5] notes.c: cleanup for "designated init" and "char ptr init"
From: Teng Long <hidden>
Date: 2022-11-09 09:07:48
Subsystem:
the rest · Maintainer:
Linus Torvalds
From: Teng Long <redacted>
Let's do some cleanup for the following two places in "append_edit()".
The first place is "char *logmsg;" need to be initialized with NULL.
The second place is "struct note_data d = { 0, 0, NULL, STRBUF_INIT };"
could be replaced with designated init format.
Signed-off-by: Teng Long <redacted>
---
builtin/notes.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/builtin/notes.c b/builtin/notes.c
index f4bab3b2f2..485439c901 100644
--- a/builtin/notes.c
+++ b/builtin/notes.c@@ -566,9 +566,9 @@ static int append_edit(int argc, const char **argv, const char *prefix) struct notes_tree *t; struct object_id object, new_note; const struct object_id *note; - char *logmsg; + char *logmsg = NULL; const char * const *usage; - struct note_data d = { 0, 0, NULL, STRBUF_INIT }; + struct note_data d = { .buf = STRBUF_INIT }; struct option options[] = { OPT_CALLBACK_F('m', "message", &d, N_("message"), N_("note contents as a string"), PARSE_OPT_NONEG,
--
2.38.1.386.g196e80358e8