Thread (31 messages) 31 messages, 3 authors, 2022-10-24

Re: [PATCH v4 6/6] builtin: patch-id: remove unused diff-tree prefix

From: Junio C Hamano <hidden>
Date: 2022-10-21 09:33:23

"Jerry Zhang via GitGitGadget" [off-list ref] writes:
From: Jerry Zhang <redacted>

From a "git grep" of the repo, no command, including diff-tree itself,
produces diff output with "diff-tree " prefixed in the header.

Thus remove its handling in "patch-id".
There is a bit of leap in the logic flow here, in that the current
state alone does not justify such a removal of the code that is not
hurting anybody.  I thought I did the necessary homework the last
time to help you update the proposed log message for this step with
necessary due diligence, like when we stopped producing it
ourselves.  The lack of third-party tools still relying on the code
we are removing here is not something we can prove easily, so
documenting that we go by faith there would not hurt, either.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help