Thread (18 messages) 18 messages, 2 authors, 2022-10-20

Re: [PATCH 02/10] git-submodule.sh: dispatch "sync" to helper

From: Glen Choo <hidden>
Date: 2022-10-20 20:43:14

Ævar Arnfjörð Bjarmason [off-list ref] writes:
Remove the cmd_sync() wrapper for "git submodule--helper sync" in
favor of dispatching the raw command-line directly to the helper.

At this point we've already parsed out the optional "--quiet" flag
that we need to support for "git submodule --quiet" (as opposed to
"git submodule <subcommand> --quiet").
For a moment, I thought this was saying that we're dropping support for
"git submodule <subcommand> --quiet" in favor of "git submodule
--quiet", but that's not true. Both are still supported, albeit in
slightly different ways:

- The subcommand "--quiet" flag is passed via $@

- The top level "--quiet" flag is parsed when we parse top level flags,
  which sets quiet=1, and thus passes "--quiet" to submodule--helper.
  We also `shift` out the "--quiet" so there's no fear of passing
  "--quiet" twice.

Hooray!
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help