Thread (1 message) 1 message, 1 author, 2022-10-14

Re: [PATCH] [OUTREACHY] t1002: modernize outdated conditional

From: Junio C Hamano <hidden>
Date: 2022-10-14 05:06:09

"nsengaw4c via GitGitGadget" [off-list ref] writes:
From: wilberforce <redacted>
This name must match ...
Tests in this script use an unusual and hard to reason about
conditional construct

    if expression; then false; else :; fi

Change them to use more idiomatic construct:

    ! expression

Cc: Christian Couder  <redacted>
Cc: Hariom Verma <redacted>
Signed-off-by: Nsengiyumva  wilberfore <redacted>
... the name you sign-off your work with.
-     if read_tree_u_must_succeed -m -u $treeH $treeM; then false; else :; fi'
+     ! read_tree_u_must_succeed -m -u $treeH $treeM'
OK.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help