Re: [PATCH] test-lib: have SANITIZE=leak imply TEST_NO_MALLOC_CHECK

From
Junio C Hamano <hidden>
Date
2022-09-29 15:29:29
Phillip Wood [off-list ref] writes:
Oh so the LD_PRELOAD breaks both sanitizers but only one of them complains
quoted
  # Add libc MALLOC and MALLOC_PERTURB test only if we are not executing
-# the test with valgrind and have not compiled with SANITIZE=address.
+# the test with valgrind and have not compiled with conflict SANITIZE
+# options.
  if test -n "$valgrind" ||
+   test -n "$SANITIZE_LEAK" ||
     test -n "$SANITIZE_ADDRESS" ||
     test -n "$TEST_NO_MALLOC_CHECK"
The indentation is dodgy, also it would be nice to keep these in
alphabetical order. Other than that this looks like a sensible fix.
Thanks, both.

Will re-queue with a local fix-up for the indentation.  As to the
ordering, I usually prefer to have new ones appended to the last
unless there are other reasons, and "keep them sorted" is such a
reason, so I may do so as well while at it.


Thread (1 message) 1 message, 1 author, last reply 2022-09-29
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help