Thread (2 messages) 2 messages, 2 authors, 2022-09-28

Re: vd/fix-unaligned-read-index-v4, was Re: What's cooking in git.git (Sep 2022, #08; Tue, 27)

From: Ævar Arnfjörð Bjarmason <hidden>
Date: 2022-09-28 17:03:00

Possibly related (same subject, not in this thread)

On Wed, Sep 28 2022, Junio C Hamano wrote:
Jeff King [off-list ref] writes:
quoted
... I have no objection to adding more comments, but I am
happy enough without them (like Junio, it may be that I'm overly
familiar with how I expect our get_be() functions to handle alignment).
...
So it's mostly just a minor annoyance for running the tests; we're
probably better not to change any code, even trivially, this late in the
release cycle.
Yup.  I never planned to merge the topic to 'master'.  The finishing
touch I expected was to help Phillip and friends with a bit of
explanation in the log message, and then it would be ready to wait
in 'next' for the next cycle.
In the interim are we interested in a minimal patch to the specific
scalar test that's finding this under SANITIZE=undefined, as running
un-cleanly will be new in this release?
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help