Thread (4 messages) 4 messages, 4 authors, 2022-09-28

Re: [PATCH] abspath.h is created.

From: Taylor Blau <hidden>
Date: 2022-09-28 15:39:53

Hi Skrab,

On Wed, Sep 28, 2022 at 01:02:22PM +0530, Skrab Sah wrote:
What is wrong here and what should i do to make it correct.
I suspect that Junio's concern is that it appears the tool you're using
to auto-generate these .h files moves the comments away from the
declaration and into the header.

I imagine that such a change would be improved if:

  - You kept the comment attached to the function declaration (and
    ensured that it was present in the header file).

  - And we dropped the "this file is auto-generated by ..." comment,
    since I don't imagine that folks will be interested in adding a new
    tool to the development toolchain.

Thanks.


Taylor
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help